[Webkit-unassigned] [Bug 118410] Segmentation fault occurred when ICU data library doesn't embed the expected encoding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118410





--- Comment #11 from Benjamin Dupont <bdupont at nds.com>  2013-07-09 07:24:57 PST ---
(In reply to comment #10)
> One thing that may be non-obvious here is that TextEncoding::name() is not just some arbitrary string, it's always an encoding name previously registered by text encoding machinery. Refusing to provide a TextCodecFactory function while registering a codec is where the bad behavior is.

In this case the problem is due to http://trac.webkit.org/changeset/64820.
In WebCore/platform/text/TextCodecICU.cpp into TextCodecICU::registerEncodingNames function, you add an alias for shift-jis (and others) even if ICU don't provide this encoding.

How can we fix that? I see some dirty solution with 'if' but I'm wondering if the previous "fix" was not better for performance purpose.

What do you think about that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.