[Webkit-unassigned] [Bug 118409] Non-power-of-two texture handle optimization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118409


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206133|review?                     |review-
               Flag|                            |




--- Comment #4 from Noam Rosenthal <noam at webkit.org>  2013-07-09 02:19:05 PST ---
(From update of attachment 206133)
View in context: https://bugs.webkit.org/attachment.cgi?id=206133&action=review

Needs a lot of cleanup, mainly names etc.

> Source/WebCore/ChangeLog:8
> +        This patch optimizes usage of handleNPOTTextures. It is not need to

is -> does

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:547
> +    if (isNPOTTSupport())

hasNPOTSupport

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1987
> +    bool invalidTex = false;

Tex -> Texture

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2072
> +    bool invalidTex = false;

Ditto

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4803
> +bool WebGLRenderingContext::handleInvalidTextures(const char* functionName, bool prepareToDraw)

What are invalid textures? Maybe this should be prepareNonRenderableTextures?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4806
> +    bool blackTexSet = false;

something like hasBlackTexture?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.