[Webkit-unassigned] [Bug 118328] Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118328


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206279|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #14 from Geoffrey Garen <ggaren at apple.com>  2013-07-08 16:51:11 PST ---
(From update of attachment 206279)
View in context: https://bugs.webkit.org/attachment.cgi?id=206279&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        I didn't add a layout test, but modified LayoutTests/fast/events/remove-target-
> +        with-shadow-in-drag-expected.txt to match with expected results in both Firefox 

remove-target-with-shadow-in-drag-expected.txt doesn't seem to call eval() or decode(). Does it really cover those cases?

I don't understand why decode() wants to roll back the callee frame. Can you explain that?

> Source/JavaScriptCore/ChangeLog:11
> +        and Chrome and now safari.

"Safari" should be capitalized.

> Source/JavaScriptCore/ChangeLog:17
> +        one frame off of topCallFrame. Error wasn't observable before becasue the stack was

Typo: "becasue" should be "because".

> Source/JavaScriptCore/ChangeLog:18
> +         being overwritten the next time addStackIfNecessary was called.

Extra space at the beginning of the line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.