[Webkit-unassigned] [Bug 118473] [GTK] Leak: GstElement* leaking in MediaPlayerPrivateGStreamer::createAudioSink()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 8 09:59:50 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118473





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-08 10:01:49 PST ---
(In reply to comment #7)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > I don't know much about gst, but I thought elements had a floating reference that is consumed when added to a container.
> > 
> > Indeed, and the proof of that is that you don't actually "adopt". So which one(s) were actually leaking?
> 
> I think all of them were leaking: gst_element_factory_make () returns a new GstElement or NULL if unable to create element. [transfer floating]

a GstElement is a GInitiallyUnowned, so it's returning a new element with a floating reference. You only need to convert it into a normal ref (which is what GRefPtr is does) if it's not added to a container that consumes the floating ref.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list