[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118306





--- Comment #15 from Christophe Dumez <dchris at gmail.com>  2013-07-08 09:23:32 PST ---
(From update of attachment 206247)
View in context: https://bugs.webkit.org/attachment.cgi?id=206247&action=review

>>>>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
>>>>> +    WTF::String url = toWTFString(adoptWK(WKURLCopyString(urlRef)));
>>>> 
>>>> I remember overloaded toWTFString accepting WKURLRef, can we use it?
>>> 
>>> I don't see it in Tools/WebKitTestRunner/StringFunctions.h. Are you sure this landed Mikhail?
>> 
>> yeah.. but it's inside Source/WebKit2/Shared/API/c/WKSharedAPICast.h.
> 
> I've tried it an after including the header the
> WebKit::toWTFString(urlRef.get()) call seems to be working. So should I use this?

No, I would not include WKSharedAPICast.h in WKTR. I would leave the patch as it is but fix the leak.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.