[Webkit-unassigned] [Bug 118405] Update Exception handling in WebAudio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118405


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206122|review?                     |review-
               Flag|                            |




--- Comment #3 from Sam Weinig <sam at webkit.org>  2013-07-05 21:24:45 PST ---
(From update of attachment 206122)
View in context: https://bugs.webkit.org/attachment.cgi?id=206122&action=review

>> Source/WebCore/ChangeLog:8
>> +        AudioBufferSourceNode, OscillatorNode and AnalyserNode don't propagate any exceptions specified in WebAudio spec.
> 
> Throwing new exceptions is risky business when it comes to backward compatibility.

While I usually am a champion for this point, given how little WebAudio content there is, I am not too worried here.

>> LayoutTests/webaudio/analyser-exception.html:34
>> +    shouldThrow("analyser.minDecibels = -20");
> 
> shouldThrow() can take a second argument with the exception name to validate that as well. If you expect a specific exception, you probably want to add that (although the spec does not seem to indicate exception names?)

I agree with Christophe, you should specify what exception you expect.  If the spec isn't specifying it clearly, we should get it updated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.