[Webkit-unassigned] [Bug 118368] Nix upstreaming - Adding Nix render theme files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118368


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206025|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2013-07-05 14:22:48 PST ---
(From update of attachment 206025)
View in context: https://bugs.webkit.org/attachment.cgi?id=206025&action=review

Use real name: o-> renderObject. i->info|paintInfo.

> Source/WebCore/platform/nix/RenderThemeNix.cpp:276
> +void RenderThemeNix::adjustProgressBarStyle(StyleResolver*, RenderStyle* style, Element *) const

Element * -> Element*

> Source/WebCore/platform/nix/RenderThemeNix.h:33
> +class RenderThemeNix : public RenderTheme {

Plenty of missing OVERRIDE.

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:29
> +#include "NotImplemented.h"

Why?

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:30
> +#include <stdio.h>

Why?

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:46
> +    return 0; // we paint on top

Fix the comment.

> Source/WebCore/platform/nix/ScrollbarThemeNix.h:33
> +class ScrollbarThemeNix : public ScrollbarTheme {

Missing OVERRIDEs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.