[Webkit-unassigned] [Bug 118392] [EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118392





--- Comment #9 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2013-07-05 00:07:46 PST ---
(From update of attachment 206090)
View in context: https://bugs.webkit.org/attachment.cgi?id=206090&action=review

I'd love to see it in the trunk. Added one comments regarding to the spellchecking and one nit.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:188
> +    *misspellingLength = static_cast<int32_t>(knownWord.length());

As I understand correctly, this callback should treat known words as spelled correctly. Therefore, its length should be set to 0 to notify WebCore to don't create spelling marker for it. Additionally, the location should be set to -1 according to the doc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:813
> +    mouseDoubleClick(10, 20, 1 /* Left button */);

Can we skip left button value and this comment here? mouseDoubleClick passes left button implicitly.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:845
> +    mouseDoubleClick(10, 20, 1 /* Left button */);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.