[Webkit-unassigned] [Bug 117733] [WK2][GTK] ASSERTION in WebKit::LayerTreeHostGtk::invalidate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117733





--- Comment #7 from Sergio Villar Senin <svillar at igalia.com>  2013-07-04 04:53:39 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > I think that m_isValid is incorrectly set to false if the GL
> > > context cannot be created (which happens if e.g. the display does
> > > not support XDamage or Xcomposite).
> > I don't think this is the case at least in my environment. Note that
> > it's set to false also at the end of ::invalidate()
> 
> Maybe you're hitting a different problem then, but I could definitely
> reproduce it as I explained.
> 
> Did you manage to reproduce it again in your environment?

What I mean is that my environment does support XDamage and XComposite, but I don't deny that the context creation may fail for some other reasons.

Our implementation is quite close to the Mac one, and it seems that we're maybe misusing m_isValid. The original purpose of that flag is to avoid flushes after an invalidation. We're setting it (incorrectly IMO) to false to track failures in the GLContext creation. So I indeed believe that your change is totally right (the flush won't happen anyway as you say if the context cannot be created).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.