[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #25 from Christophe Dumez <dchris at gmail.com>  2013-07-04 03:32:20 PST ---
(In reply to comment #24)
> (From update of attachment 206009 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206009&action=review
> 
> >>>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:474
> >>>>          return JSStringCreateWithCharacters(0, 0);
> >>> 
> >>> It looks a bit weird that we return 0 below but not here.
> >> 
> >> That's a good point.  Shall I do
> >> JSStringRef jsString = attributeValue ? JSStringCreateWithUTF8CString(attributeValue)
> >>                                       : JSStringCreateWithCharacters(0, 0);
> > 
> > Just "return 0;" here for consistency.
> 
> I've just been looking through the file and JSStringCreateWithCharacters(0, 0) is definitely the common way to return an empty JSStringRef. Should I not do that instead for consistency?

But the mac implementation seems to return 0 is those cases, right? Anyway, this is not strictly related to your fix so you can keep using JSStringCreateWithCharacters(0, 0) in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.