[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #24 from Brian Holt <brian.holt at samsung.com>  2013-07-04 03:07:10 PST ---
(From update of attachment 206009)
View in context: https://bugs.webkit.org/attachment.cgi?id=206009&action=review

>>>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:474
>>>>          return JSStringCreateWithCharacters(0, 0);
>>> 
>>> It looks a bit weird that we return 0 below but not here.
>> 
>> That's a good point.  Shall I do
>> JSStringRef jsString = attributeValue ? JSStringCreateWithUTF8CString(attributeValue)
>>                                       : JSStringCreateWithCharacters(0, 0);
> 
> Just "return 0;" here for consistency.

I've just been looking through the file and JSStringCreateWithCharacters(0, 0) is definitely the common way to return an empty JSStringRef. Should I not do that instead for consistency?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.