[Webkit-unassigned] [Bug 118326] Preparing WebCore to receive Nix Port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118326


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205945|review?                     |review-
               Flag|                            |




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2013-07-03 14:05:37 PST ---
(From update of attachment 205945)
View in context: https://bugs.webkit.org/attachment.cgi?id=205945&action=review

> Source/WebCore/platform/DragImage.h:64
> -#elif PLATFORM(GTK)
> +#elif PLATFORM(GTK) || PLATFORM(NIX)
>      typedef cairo_surface_t* DragImageRef;

I wonder why this isn't under USE(CAIRO).

> Source/WebCore/platform/FileSystem.h:124
> -#elif PLATFORM(GTK)
> +#elif PLATFORM(GTK) || PLATFORM(NIX)
>  typedef GFileIOStream* PlatformFileHandle;

I wonder if we should add USE(GLIB). It's quite confusing that "G" types are used by two platforms, one of which doesn't have a "G" in its name.

> Source/WebCore/platform/PlatformMenuDescription.h:38
> +#elif PLATFORM(NIX)
> +#include <wtf/Vector.h>

Why is this needed?  You are not changing this file in any other way, and this file is not using Vector.

> Source/WebCore/platform/audio/FFTFrame.h:189
> +#if PLATFORM(NIX)
> +    void scalePlanarData(float scale);
> +    OwnPtr<WebKit::WebFFTFrame> m_fftFrame;
> +#endif // PLATFORM(NIX)

Ugh, WebCore is not supposed to know anything about WebKit. This is a terrible layering violation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.