[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 3 10:10:41 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=118307
--- Comment #17 from Christophe Dumez <dchris at gmail.com> 2013-07-03 10:12:39 PST ---
(From update of attachment 206006)
View in context: https://bugs.webkit.org/attachment.cgi?id=206006&action=review
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:806
> + const char* attributeValue = "";
I would initialize to 0 instead
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:815
> + JSStringRef jsStr = JSStringCreateWithUTF8CString(attributeValue);
no abbreviations as per coding style. Please use "jsString".
Also, mac implementation seems to return 0 if not found. So maybe something like:
JSStringRef jsString = attributeValue ? SStringCreateWithUTF8CString(attributeValue) : 0;
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:476
> + const char* attributeValue = "";
Same comment as for DRT.
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:485
> + JSStringRef jsStr = JSStringCreateWithUTF8CString(attributeValue);
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list