[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #15 from Brian Holt <brian.holt at samsung.com>  2013-07-03 08:31:13 PST ---
(From update of attachment 206002)
View in context: https://bugs.webkit.org/attachment.cgi?id=206002&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:56
>>  static gchar* attributeSetToString(AtkAttributeSet* attributeSet)
> 
> Since this function is always called as:
> "GOwnPtr<gchar> attributeData(attributeSetToString(atk_object_get_attributes(ATK_OBJECT(m_element))));"
> 
> How about changing the prototype to:
> static gchar* getAtkObjectAttributesAsString(AtkObject *accessible); ?
> 
> This way, we handle freeing the list inside the function instead of the caller.

That seems very reasonable to me, I'll make the change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.