[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #13 from Brian Holt <brian.holt at samsung.com>  2013-07-03 08:09:26 PST ---
(From update of attachment 206002)
View in context: https://bugs.webkit.org/attachment.cgi?id=206002&action=review

Great comments, thanks very much!

>> Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp:97
>> +    AtkAttributeSet* attributeSet(atk_object_get_attributes(parent));
> 
> I think the assignment looked better before.

My mistake, will change that.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:-78
>> -    attributesClear(atkAttributes.get());
> 
> Missing call to atk_attribute_set_free()?

No, the attributeSet will get freed in AccessibilityUIElement::allAttributes() where it is created.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.