[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #12 from Christophe Dumez <dchris at gmail.com>  2013-07-03 07:57:23 PST ---
(From update of attachment 206002)
View in context: https://bugs.webkit.org/attachment.cgi?id=206002&action=review

> Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp:97
> +    AtkAttributeSet* attributeSet(atk_object_get_attributes(parent));

I think the assignment looked better before.

> Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp:98
>      for (GSList* attributes = attributeSet; attributes; attributes = attributes->next) {

Would be nice to use AtkAttributeSet here instead of GSList.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:808
> +    for (GSList* attributes = attributeSet; attributes; attributes = attributes->next) {

Would be nice to use AtkAttributeSet here instead of GSList.

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:811
> +            attributeValue.set(g_strdup(atkAttribute->value));

If we call JSStringCreateWithUTF8CString() before freeing the attributes list, we would not need this strdup() and attributeValue could be a const gchar*.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:160
>      for (GSList* attributes = attributeSet; attributes; attributes = attributes->next) {

Would be nice to use AtkAttributeSet here instead of GSList.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:59
> +    for (GSList* attributes = attributeSet; attributes; attributes = attributes->next) {

Would be nice to use AtkAttributeSet here instead of GSList.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:-78
> -    attributesClear(atkAttributes.get());

Missing call to atk_attribute_set_free()?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:477
> +    for (GSList* attributes = attributeSet; attributes; attributes = attributes->next) {

AtkAttributeSet*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.