[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118307





--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2013-07-03 01:40:42 PST ---
(In reply to comment #4)
> I think the EFL bot is right. we cannot distinguish GSList and AtkAttributeSet
> if one is a typedef to the other :(

I wonder why this is a problem while building EFL and not while building GTK. Any idea?

Another "option" is to propose to ATK developers, making the most of the fact that they are defining/changing the API now for the incoming versions, to get rid of that typedef and just use a GSList. That would take more time of course and could even make sense in the long run, yet would not fix the issue at hand here (which might happen in the future in a similar scenario).

> Using the existing GSList specialization would not be great because it would 
> only free the list but not its items.

Indeed. Using the GSList specialization would leak not only every single data field in the GSList, but also two allocated gchar* for each of them too, since AtkAttribute is a struct.

> Maybe we should stick with atk_attribute_set_free() then?
> unless someone has a better proposal.

I would propose to investigate why this is a problem in EFL and not in GTK, and try to get it sorted out, because using a GOwnPtr specialization is, in my opinion, clearer and cleaner than the current approach we have now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.