[Webkit-unassigned] [Bug 118297] [ATK] Leak: leaks in AccessibilityUIElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118297


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205916|review?                     |commit-queue+
               Flag|                            |




--- Comment #15 from Christophe Dumez <dchris at gmail.com>  2013-07-02 08:26:23 PST ---
(From update of attachment 205916)
View in context: https://bugs.webkit.org/attachment.cgi?id=205916&action=review

>>> Tools/ChangeLog:8
>>> +        Reviewed by Christophe Dumez.
>> 
>> The patch did not get r+. So It is a bit early to update this line :)
> 
> Sorry, I didn't realise that we only do that after r+. Because I'm not a committer I thought I could make the change to avoid having to upload another patch after r+ ...

You don't have to reupload a patch after r+ unless there are nits to fix. This line gets automatically updated when landing after a r+.

>>> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:425
>>> +    GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", textWithReplacedCharacters.get()));
>> 
>> Would you fix the same issue in Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp in the same patch please?
> 
> It turns out that this has already been fixed in WKTR, but it wasn't applied to the DRT.

Oh, my bad. I misread my grep output.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.