[Webkit-unassigned] [Bug 118057] [CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 1 12:50:45 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=118057
Dave Hyatt <hyatt at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #205798|review? |review-
Flag| |
--- Comment #7 from Dave Hyatt <hyatt at apple.com> 2013-07-01 12:52:43 PST ---
(From update of attachment 205798)
View in context: https://bugs.webkit.org/attachment.cgi?id=205798&action=review
Looks fine. Minor quibble.
> Source/WebCore/rendering/RenderRegion.cpp:58
> + , m_computedAutoHeight(0)
> + , m_hasComputedAutoHeight(false)
I would flip these.
> Source/WebCore/rendering/RenderRegion.h:214
> + LayoutUnit m_computedAutoHeight;
> + bool m_hasComputedAutoHeight : 1;
I would flip these to put m_hasComputedAutoHeight with the other bits.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list