[Webkit-unassigned] [Bug 118246] New: Fix cast-align warning in WebCore/css/StylePropertySet.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 08:08:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118246

           Summary: Fix cast-align warning in
                    WebCore/css/StylePropertySet.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: koivisto at iki.fi, akling at apple.com


/home/oszi/WebKit/Source/WebCore/css/StylePropertySet.h:181:189: warning: cast from 'const char*' to 'const WebCore::StylePropertyMetadata*' increases required alignment of target type [-Wcast-align]

This line introduced in https://trac.webkit.org/changeset/133138

179: inline const StylePropertyMetadata* ImmutableStylePropertySet::metadataArray() const
180: {
181:     return reinterpret_cast<const StylePropertyMetadata*>(&reinterpret_cast<const char*>((&static_cast<const ImmutableStylePropertySet*>(this)->m_storage))[m_arraySize * sizeof(CSSValue*)]);
182: }

This long line is so obfuscated for me. :) Could you check it this warning is valid
or can be supressable by using reinterpret_cast_ptr instead of reinterpret_cast ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list