[Webkit-unassigned] [Bug 118234] [GTK] Menu list button doesn't use the text color from the theme

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 08:03:18 PDT 2013


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |mrobinson at webkit.org

--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2013-07-01 08:05:15 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 205793 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=205793&action=review
> > 
> > > Source/WebCore/platform/gtk/RenderThemeGtk.cpp:220
> > > +    style->setColor(menuListButtonTextColor(element));
> > 
> > Doesn't this prevent the CSS theme from adjusting the text color?
> I'm not sure, maybe the css color is overriden after this. Check RenderThemeMac::adjustMenuListStyle, mac also sets the color there.

It might be worth overriding it always, but it also should be possible to avoid it, I think, by only overriding it if it is set to the default color.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list