No subject


Mon Jan 28 08:41:14 PST 2013


> > We should simply enable the compile-time flag all the time if we're exposing the API. A feature is usually not enabled only if it isn't implemented or ready.
> In this case should I remove all PAGE_VISIBILITY_API references:
> Source/WTF/wtf/FeatureDefines.h
> Source/WebCore/dom/Document.cpp
> Source/WebCore/dom/Document.h
> Source/WebCore/page/Frame.cpp
> Source/WebCore/page/Frame.h
> Source/WebCore/page/Page.cpp
> Source/WebCore/page/Page.h
> Source/WebCore/page/PageVisibilityState.cpp
> Source/WebCore/page/PageVisibilityState.h
> Source/WebCore/page/Settings.cpp
> Source/WebCore/page/Settings.h
> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp
> Tools/Scripts/webkitperl/FeatureList.pm
> Tools/qmake/mkspecs/features/features.pri
> And WebKit2 files? 
> 
> Or just doing the assumption that this feature is always enabled in QWebPageAdapter?

We should just make the feature enabled by default in our build system and assume that the feature is enabled in Qt-specific sources. We shouldn't change cross-port code as other port might want or not to enable this feature.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list