No subject

Mon Jan 28 08:41:14 PST 2013

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:240
> +            break;

It seems that you didn't apply Chris' comment properly. I am in a favor of return here so we could call ADD_FAILURE outside the loop. Moreover, would be nice to add additional indent here.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:290
> +            break;

Ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:396
> +    ASSERT_TRUE(waitUntilTrue(callbacksExecutionStats.settingChange));

Please make additional line here as this is rather part of cleaning.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:416
> +    ASSERT_FALSE(waitUntilTrue(callbacksExecutionStats.settingChange, defaultTimeoutInSeconds));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.