No subject


Mon Jan 28 08:41:14 PST 2013


    - Avoid calling connectionDidClose() twice.

    From g_source_create_source:

    "It is meaningless to specify G_IO_ERR or G_IO_HUP in condition; these
    conditions will always be reported output if they are true."

    As readyReadHandler() will be called anyway for G_IO_HUP e G_IO_ERR, let
    it in charge of calling connectionDidClose instead of adding another
    event source, just like EFL and Qt does.

    - Check the status of m_cancellable().

    EventSource::cancel() cancels m_cancellable, which triggers this
    source with the current condition. A check for the cancellable status
    is needed to check whether it was cancelled or not.

    - Do not close the child socket when it's terminated.

    This action is delegated to Connection::platformInvalidate.
    Closing it here can raise race conditions when polling the sockets
    from the WorkQueue mainloop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list