[Webkit-unassigned] [Bug 106739] Fix the atomicIncrement implementation for MIPS GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106739





--- Comment #18 from Simon Hausmann <hausmann at webkit.org>  2013-01-31 23:06:43 PST ---
(From update of attachment 184530)
View in context: https://bugs.webkit.org/attachment.cgi?id=184530&action=review

>> Source/WTF/wtf/Atomics.cpp:90
>> +int64_t __sync_add_and_fetch_8(int64_t volatile* addend, int64_t value)
> 
> __sync_add_and_fetch_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]

So this is a workaround for a bug in the toolchain that is missing this symbol? Maybe that should be explained in a comment and the ChangeLog? What if the toolchain is newer and suddenly provides the symbol? Are version guards missing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.