[Webkit-unassigned] [Bug 108509] [Chromium] Select multi-word misspelling on context click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108509





--- Comment #10 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-01-31 16:45:45 PST ---
(In reply to comment #8)
> (From update of attachment 185887 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185887&action=review
> 
> I had suggested moving in a follow up change because now the diff doesn't show your changes.  Anyway, this is OK too.

Sorry about the confusion.

> > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:149
> > +// Helper function to get misspelling on which context menu is to be invoked
> > +// for asynchronous spellcheck. This function changes the selection only when
> > +// there were no selected characters.
> 
> Remove this comment.

Removed.

> > Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:120
> > +    if (word == WebString::fromUTF8("wellcome"))
> > +        append(suggestions, WebString::fromUTF8("welcome"));
> 
> Why do we copy and swap?  Why can't we append to |suggestions| directly?

WebVector has a constant size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.