[Webkit-unassigned] [Bug 108509] [Chromium] Select multi-word misspelling on context click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108509





--- Comment #5 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-01-31 16:04:48 PST ---
(In reply to comment #2)
> (From update of attachment 185850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185850&action=review
> 
> As a follow up, it would be nice if we moved the spellchecking code into a helper function out of getCustomMenuFromDefaultItems() since that function is > 200 lines.

Moved the async part of the spellchecking code into "selectMisspellingAsync()", which is symmetric to the synchronous version "selectMisspelledWord()". Do we need more refactorings here?

> > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:295
> > +                    if (markerRange->startOffset() == selectionRange->startOffset() && markerRange->endOffset() == selectionRange->endOffset()) {
> 
> Could you use WebCore::areRangesEqual() here instead of comparing start and end?


Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.