[Webkit-unassigned] [Bug 108498] [Chromium] Add two-word misspelling to mock spellchecker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108498





--- Comment #6 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-01-31 12:02:05 PST ---
(In reply to comment #3)
> > Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:76
> > +        int maxWordLength = static_cast<int>(stringText.length()) - wordOffset;
> > +        int wordLength;
> 
> I think you would have fewer casts if you made all the length types unsigned.  Conceptually, a negative length doesn't make sense.

As we discussed offline, keeping int types because WTF::String::find() returns int types that can be negative.

> > Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:167
> > +        m_misspelledWords.append(WTF::String::fromUTF8(misspelledWords[i]));
> 
> Nit: remove WTF::

Done.

> > Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:73
> > +    Vector<WTF::String> m_misspelledWords;
> 
> Nit: remove WTF::

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.