[Webkit-unassigned] [Bug 107398] [GTK][GStreamer] FullscreenVideoControllerGtk implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107398


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185497|review?                     |review+
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2013-01-31 05:11:31 PST ---
(From update of attachment 185497)
View in context: https://bugs.webkit.org/attachment.cgi?id=185497&action=review

> Source/WebCore/platform/graphics/gtk/FullscreenVideoControllerGtk.h:82
> +    unsigned long m_exitFullcreenActionActivateSignalHandler;

Two naming nits about this class: these really aren't handlers but rather ids, so how about s/Handler/ID/? And secondly, keeping Gtk out of this class' name would avoid having an #if PLATFORM() block for each of GStreamer-based ports in the MediaPlayerPrivate part of this patch, wouldn't it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.