[Webkit-unassigned] [Bug 107737] [Chromium] Editor::m_compositionNode not updated on HTMLInputElement::setValue()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107737





--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-31 03:55:41 PST ---
(From update of attachment 185674)
View in context: https://bugs.webkit.org/attachment.cgi?id=185674&action=review

> Source/WebCore/editing/Editor.cpp:2403
> +bool Editor::cancelCompositionIfRequired()

IfRequired doesn't really tell us what that requirement is, and when we should be calling this function.
How about something like cancelCompositionIfSelectionIsInvalid, cancelCompositionIfSelectionIsOutdated, or cancelCompositionIfSelectionIsOrphaned?
(orphaned is a adjective we use to describe positions in a detached DOM node. Look for "orphaned" in FrameSelection/VisibleSelection/VisiblePosition).

> Source/WebCore/editing/Editor.cpp:2407
> +    if (hasComposition() && !ignoreCompositionSelectionChange() && !getCompositionSelection(start, end)) {

I would have negated this condition so that you can immediately return false instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.