[Webkit-unassigned] [Bug 108386] [Chromium] WebWidget::selectionBounds should return the bounds in document space

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 00:39:32 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108386





--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2013-01-31 00:41:32 PST ---
(From update of attachment 185583)
View in context: https://bugs.webkit.org/attachment.cgi?id=185583&action=review

> Source/WebKit/chromium/public/WebWidget.h:204
> +    virtual bool documentSelectionBounds(WebRect& anchor, WebRect& focus) const { return false; }

nit: WebWidget as an interface generally isn't supposed to know about DOM-related concepts.
this method name seems to suggest that coordinates are returning in document space instead
of viewport space?  such a method probably belongs on WebView instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list