[Webkit-unassigned] [Bug 107737] [Chromium] Editor::m_compositionNode not updated on HTMLInputElement::setValue()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 20:05:38 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107737





--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-30 20:07:38 PST ---
(From update of attachment 185663)
View in context: https://bugs.webkit.org/attachment.cgi?id=185663&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1365
> +        unsigned start, end;
> +        Editor* editor = frame->editor();
> +        if (editor->hasComposition() && !editor->ignoreCompositionSelectionChange() && !editor->getCompositionSelection(start, end)) {

Can we extract this as a member function of Editor? It seems like we're duplicating code in WebView.m here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list