[Webkit-unassigned] [Bug 108164] Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108164


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185322|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Benjamin Poulain <benjamin at webkit.org>  2013-01-30 15:41:14 PST ---
(From update of attachment 185322)
View in context: https://bugs.webkit.org/attachment.cgi?id=185322&action=review

Okay from me given Noam already reviewed.

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:98
> +    // LayerTreeRendererClient Methods

Period.

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:98
> -    // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_coordinatedLayerTreeHostProxy.
> +    // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_client.
>      // Currently, QQuickWebPage::updatePaintNode() locks the main thread before calling both methods.
>      void purgeGLResources();
>      void setActive(bool);

This is backward. You should not document weird thread consistency issues, you should encapsulate them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.