[Webkit-unassigned] [Bug 107831] [chromium] Make selection handling work in applyPageScaleInCompositor mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107831





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2013-01-30 15:08:23 PST ---
(From update of attachment 184508)
View in context: https://bugs.webkit.org/attachment.cgi?id=184508&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1386
> +    if (frame()->page()->settings()->applyPageScaleFactorInCompositor()) {
> +        unscaledBase.x /= view()->pageScaleFactor();
> +        unscaledBase.y /= view()->pageScaleFactor();
> +        unscaledExtent.x /= view()->pageScaleFactor();
> +        unscaledExtent.y /= view()->pageScaleFactor();
> +    }
> +    VisiblePosition basePosition = visiblePositionForWindowPoint(unscaledBase);
> +    VisiblePosition extentPosition = visiblePositionForWindowPoint(unscaledExtent);

There got to be a better way of achieving this. At minimum, we should have some helper function that automatically scale both x and y.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.