[Webkit-unassigned] [Bug 107692] [Curl] There is no way for a WebKit client to set the Curl cookie jar path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107692


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185502|review?                     |review-
               Flag|                            |




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org>  2013-01-30 09:54:05 PST ---
(From update of attachment 185502)
View in context: https://bugs.webkit.org/attachment.cgi?id=185502&action=review

Thanks for working on this.  I think it would be cleaner if you encapsulated this in a helper function (like I did with the "certificatePath").  Then we can provide port-specific logic for identifying where the cookie jar should live.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:122
> +    , m_cookieJarFileName("cookies.dat")

I would prefer you write a helper function like "certificatePath" that encapsulates the identification of this cook jar.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:137
> +        m_cookieJarFileName = fastStrDup(cookieJarPath);

This logic should go in the helper function.  Then I can add a CF-variant without cluttering the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.