[Webkit-unassigned] [Bug 108288] On EWS bots, run tests on patch once instead of twice if some tests fail.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108288





--- Comment #8 from Eric Seidel <eric at webkit.org>  2013-01-30 02:18:28 PST ---
(From update of attachment 185388)
View in context: https://bugs.webkit.org/attachment.cgi?id=185388&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:645
> -        res, err, _ = logging_run(['--no-retry-failures', '--clobber-old-results', 'failures/flaky'], tests_included=True, host=host)
> +        res, err, _ = logging_run(['--retry-failures=0', '--clobber-old-results', 'failures/flaky'], tests_included=True, host=host)

I think users use --no-retry-failures on NRWT, so this may be slightly confusing and worth announcing on webkit-dev.

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:197
> +        # FIXME: We'll want to add LayoutTestResults.flaky_tests() first
> +        # Only report flaky tests if we were successful at parsing results.json and archiving results.
> +        # if first_results and first_results_archive:
> +        #     self._report_flaky_tests(first_results.failing_test_results(), first_results_archive)

So now we're going to depend on NRWT reporting the flaky tests to us?  That sounds reasonable, but may not work for other methods of testing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.