[Webkit-unassigned] [Bug 106553] [V8] Add IDL 'enum' support to CodeGeneratorV8.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106553





--- Comment #23 from Nils Barth <nbarth at google.com>  2013-01-29 17:26:00 PST ---
(In reply to comment #21)
> (From update of attachment 185173 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185173&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1263
> > +    const String string = String(v);
> 
> This is an odd line.  Why not:
> 
> String string = v;
> 
> ?

No reason -- I'm not familiar with V8/WebCore conventions or classes;
what should I do (well, you have a suggestion -- could you elaborate)?

A couple questions:
1. Should we avoid explicit conversions?
  (Makes sense, just checking)
  so: "String string = v" instead of "String string = String(v)" ?

2. Should we use const -- I'm just converting so I can compare,
  and not modifying "string".
  so: "const String string = v" instead of "String string = v" ?

3. How should I be comparing strings?
  v is a V8StringResource I believe, which doesn't have a comparison,
  so I'm casting it to String and comparing those, which works;
  is it The Right Way to do it?

Oh, and pleasure to be working with you, Mr. Barth.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.