[Webkit-unassigned] [Bug 108124] Web Inspector: in tests rename never running 'test' to be less cryptic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108124





--- Comment #6 from Peter Rybin <prybin at chromium.org>  2013-01-29 05:34:44 PST ---
(In reply to comment #5)
> (From update of attachment 185115 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185115&action=review
> 
> > LayoutTests/inspector/console/console-eval-scoped.html:6
> > +// This function is never executed directly, but is stringified, sent and reconstructed from string in frontend page.
> 
> I'm not sure if copy-pasting the comment everywhere is a good idea. We can have a comment only in the inspecor-test.js which uses the function but to my taste the function name looks self-descriptive enough.

I thought that using a function as a convenient string literal is quite unexpected technique and deserves an explicit annotation.
I don't think adding an extra line of comment is a problem. This shouldn't become a standard annotation, the shorter form is fine for future usage.
However, copy-pasting boilerplate will probably make this line a standard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.