[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #106 from Hin-Chung Lam <hclam at google.com>  2013-01-28 20:25:59 PST ---
(In reply to comment #105)
> (In reply to comment #98)
> > (In reply to comment #96)
> > > I submitted an unreviewed build fix: http://trac.webkit.org/changeset/141033
> > > 
> > > The use SkMutex is not necessary in this code so remove it would make Mac build happy. The reason for undefined reference is because of component build and SK_API.
> > 
> > We definitely need the SkMutex here. If we don't provide our own mutex, skia will fall back to use a static skmutex arrray. And the skmutex array has 30 mutex in it used in a ring fashion. 
> > The problem is that 2 DiscardablePixelRef can later on use the same mutex and lead to deadlocks.
> 
> (In reply to comment #102)
> > Was this failure caused by this patch too? 
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Fvirtual%2Fdeferred%2Ffast%2Fimages%2Ficon-0colors.html
> 
> Keishi, can you file a bug and mark this as debug crash? We'll come up with a fix today.

Not today but I mean this week.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.