[Webkit-unassigned] [Bug 106815] [Chromium] Tests and fixes for spell checker behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106815





--- Comment #30 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-01-28 18:01:54 PST ---
(In reply to comment #28)
> (From update of attachment 185091 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185091&action=review
> 
> As Tony pointed, The large part of the test code is a boilerplate. Can we get rid of it?

Moved boilerplate into LayoutTests/editing/spelling/resources/util.js

> 
> > LayoutTests/editing/spelling/spelling-double-clicked-word-with-underscores.html:16
> > +        finishJSTest();
> 
> It looks we have no "FAIL" output when the test is timed out.
> Let's explicitly fail here. Same for other tests.
> 
> > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:300
> > +                        selectionRange.clear();
> 
> Nit: It looks we don't need this clear() call.

Removed the clear() call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.