[Webkit-unassigned] [Bug 106815] [Chromium] Tests and fixes for spell checker behavior
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 16:31:49 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=106815
--- Comment #28 from Hajime Morrita <morrita at google.com> 2013-01-28 16:33:46 PST ---
(From update of attachment 185091)
View in context: https://bugs.webkit.org/attachment.cgi?id=185091&action=review
As Tony pointed, The large part of the test code is a boilerplate. Can we get rid of it?
> LayoutTests/editing/spelling/spelling-double-clicked-word-with-underscores.html:16
> + finishJSTest();
It looks we have no "FAIL" output when the test is timed out.
Let's explicitly fail here. Same for other tests.
> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:300
> + selectionRange.clear();
Nit: It looks we don't need this clear() call.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list