[Webkit-unassigned] [Bug 106842] adding support for DiscardablePixelRef for caching lazily decoded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106842





--- Comment #89 from Min Qin <qinmin at chromium.org>  2013-01-28 15:16:32 PST ---
(From update of attachment 185049)
View in context: https://bugs.webkit.org/attachment.cgi?id=185049&action=review

>> Source/WebCore/ChangeLog:8
>> +        This change allows using discardable memory in deferred image decoding path.
> 
> Nit:  in deferred -> in the deferred

Done.

>> Source/WebCore/ChangeLog:11
>> +        Separate caching policy for discardable memory
> 
> This is not a sentence.

This line is covered in the line below, removed.

>> Source/WebCore/ChangeLog:12
>> +        Discardable memory allocation could fail, fall back to heap allocation in that case.
> 
> Nit:  comma splice:  use semicolon instead of comma, or break this into two sentences.

Done.

>> Source/WebCore/ChangeLog:13
>> +        Separate cache size limit for heap entries, no limit on discardable entries
> 
> Same here.  This is also not a sentence.

Done.

>> Source/WebCore/ChangeLog:18
>> +        (WebCore::DiscardablePixelRefAllocator::allocPixelRef):
> 
> You really should have a description of the per-file changes here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.