[Webkit-unassigned] [Bug 107509] [Mac] Update PageVisibilityState when WebView is hidden / visible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 14:44:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107509





--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org>  2013-01-28 14:46:12 PST ---
(In reply to comment #10)
> (From update of attachment 184636 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184636&action=review
> 
> > Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:62
> > +    virtual void deinitializeView(WebView *) { }
> > +    virtual void deinitializeView(WKView *) { }
> 
> I'm not a fan of this made up word.  I would prefer cleanupView().

As discussed on IRC we went with teardownView since tests normally have setup/teardown naming conventions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list