[Webkit-unassigned] [Bug 107364] Improve PageVisibility API with enums

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107364





--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org>  2013-01-28 14:45:16 PST ---
(In reply to comment #8)
> (From update of attachment 184635 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184635&action=review
> 
> No COMPILE_ASSERT() statements?

Went with the switch statement handing all cases.

> > Source/WebKit/mac/WebView/WebView.mm:412
> > +static PageVisibilityState corePageVisibilityState(WebPageVisibilityState visibilityState)
> 
> I think it would be best to name this "core(WebPageVisibilityState visibilityState)" since C++ will disambiguate based on the argument type.

Renamed to core.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.