[Webkit-unassigned] [Bug 107813] Web Inspector: Filters on Console panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107813





--- Comment #9 from Dmitry Zvorygin <zvorygin at chromium.org>  2013-01-28 09:15:47 PST ---
(From update of attachment 184499)
View in context: https://bugs.webkit.org/attachment.cgi?id=184499&action=review

>> Source/WebCore/inspector/front-end/ConsoleView.js:461
>> +        var filterSubMenu = contextMenu.appendSubMenuItem("Filter", !(this._messageURLFilters.length || (srcElement && srcElement.message.url)));
> 
> UIString("Filter")

Fixed.

>> Source/WebCore/inspector/front-end/ConsoleView.js:471
>> +            filterSubMenu.appendCheckboxItem(new WebInspector.ParsedURL(this._messageURLFilters[i]).displayName + " (" + this._urlToMessageCount[this._messageURLFilters[i]] + ")", this._removeMessageUrlFilter.bind(this, i), true);
> 
> You could use message format: String.sprintf("%s (%d)", displayName, count)

Done.

>> Source/WebCore/inspector/front-end/ConsoleView.js:502
>> +        if (idx == -1)
> 
> index (no abbreviations)

Fixed.

>> Source/WebCore/inspector/front-end/ConsoleView.js:515
>> +    _shouldBeVisible: function(msg)
> 
> message

Fixed.

>> Source/WebCore/inspector/front-end/ConsoleView.js:520
>> +    _updateMessageList: function()
> 
> A test?

Done.

>> Source/WebCore/inspector/front-end/ConsoleView.js:811
>> +                this.messagesElement.insertBefore(element, node);
> 
> insertBefore(element, null) would work as appendChild and just as fast (see ContainerNode.cpp:241), no need to fork the code here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.