[Webkit-unassigned] [Bug 104662] [EFL][GTK][Mac][Chromium] Share accessibility LayoutTest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104662





--- Comment #15 from Mario Sanchez Prada <mario at webkit.org>  2013-01-28 01:56:22 PST ---
(In reply to comment #14)
> But those are common test. Shouldn't we put them on common folder?

The problem is that they are platform specific tests, and so they should live under LayoutTests/platform/<platform>, not under LayoutTests/accessibility/<platform>.

However, I've just realized of another problem with having a LayoutTests/platform/atk directory is that "atk" is not a valid platform name when it comes to tests (see "Platform options" section in the output of 'run-webkit-tests --help') and so I don't think this will magically work for GTK and EFL unless you also patch the run-webkit-tests script.

I guess all you would need to make it work that way would be to add the LayoutTests/platform/atk directory in _search_paths() both in layout_tests/port/gtk.py and layout_tests/port/efl.py, but you'd better double check that in case I' missing something.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.