[Webkit-unassigned] [Bug 107552] Web Inspector: Show element style panes in a tabbed pane when they are below the DOM tree pane.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107552


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184758|review?                     |review-
               Flag|                            |




--- Comment #14 from Pavel Feldman <pfeldman at chromium.org>  2013-01-28 01:27:22 PST ---
(From update of attachment 184758)
View in context: https://bugs.webkit.org/attachment.cgi?id=184758&action=review

> Source/WebCore/ChangeLog:8
> +        Made WebInspector.SidebarPane extend WebInspector.View.

Sounds like a separate change. Please extract it.

> Source/WebCore/inspector/front-end/SidebarView.js:141
> +    _getEffectiveSidebarPosition: function(sidebarPosition)

no get prefixes in getters please

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.