[Webkit-unassigned] [Bug 107931] [EFL][WK2] Introduce a WebView class as counterpart for WKViewRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107931





--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-01-28 00:56:33 PST ---
(From update of attachment 184760)
View in context: https://bugs.webkit.org/attachment.cgi?id=184760&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:131
>> +    m_webPageProxy->close();
> 
> So we don't free m_evasObject here?

No, for reasons discussed on IRC

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:922
>> +    WKRetainPtr<WKURLRef> wkActiveURL = WKPageCopyActiveURL(wkPage());
> 
> Needs to be adopted.

Fixed locally

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:923
>> +    WKRetainPtr<WKStringRef> wkURLString = WKURLCopyString(wkActiveURL.get());
> 
> Ditto.

Fixed locally

>> Source/WebKit2/UIProcess/API/efl/EwkView.h:106
>> +class WebView {
> 
> Shouldn't this be RefCounted?

We should probably move it to APIObject in another patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.