[Webkit-unassigned] [Bug 106815] [Chromium] Tests and fixes for spell checker behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106815





--- Comment #25 from Hajime Morrita <morrita at google.com>  2013-01-27 16:25:36 PST ---
(From update of attachment 184825)
View in context: https://bugs.webkit.org/attachment.cgi?id=184825&action=review

I'm wondering whether we can get rid of addSpellingMarker().
In general, Internals object is for inspecting hidden state from JS and
issuing a action with side effect through the Internals object isn't a good idea.
It can be a signal of testing something that never happens in real Web.

One possible workaround is to tell MockSpellChecker a multi-word misspelling candidate.
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp
So that it marks the text as mis-spelled. This approach is more like end-to-end than unit testing, which WebKit traditionally prefers.

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:289
> +                RefPtr<Range> markerRange = selectionRange->cloneRange(exceptionCode);

Nit: Can this fail?  If not, we can use ASSERT_NO_EXCEPTION macro to clarify that fact.
https://lists.webkit.org/pipermail/webkit-dev/2011-December/018908.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.