[Webkit-unassigned] [Bug 91440] Implement 'vmin' and 'vmax' from CSS3 values and units
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 27 02:29:07 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=91440
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2013-01-27 02:31:03 PST ---
Attachment 184907 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute-expected.html', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute.html', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-expected.html', u'LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSGrammar.y.in', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValue.idl', u'Source/WebCore/css/LengthFunctions.cpp', u'Source/WebCore/platform/Length.h', u'Source/WebCore/rendering/RenderBox.cpp']" exit_code: 1
Source/WebCore/css/CSSParser.cpp:1642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/css/CSSParser.cpp:1647: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/css/CSSPrimitiveValue.h:98: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/css/CSSPrimitiveValue.h:99: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/css/CSSPrimitiveValue.h:100: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/css/CSSPrimitiveValue.h:101: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 6 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list